-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assets 32349 #24
Assets 32349 #24
Conversation
@cheintzman I am getting redirected to landing page, if I am logged-in and on faq page. Shouldn't user be redirected to /assets page from https://assets-32349--adobe-gmo--hlxsites.hlx.page/faq if user is logged-in? |
@shiv-gup Yes, that would be the ultimate end goal, however due to the way public pages are handled, the method used here to determine whether a user is logged in cannot be used on public pages. It will require changing/adding code to security.js and security-imslibs.js in order to resolve the issue properly. These changes will get the logo working properly for majority of the site until that gets part resolved. |
@cheintzman can you share the JIRA story where the changes were requested. I feel for now just making the logo image configurable should be good. From all pages if user clicks on logo, the same page user should be redirected to(not dependent on user login status). Please check once with Debbie and Diana for requirement. |
@shiv-gup This is the initial story: DXI-23112 Diana had asked that the /assets page be considered the "home" page once the use is logged in, and the landing page be considered the home page for unauthenticated users. Debbie had mentioned I should make this change after the RCP since the security files needed some more people to be involved in order to resolve it properly. |
JIRA: ASSETS-32349
Made changes to dynamically set the href of the adp-logo depending on whether the user is logged in and/or whether the user is navigating the /qa section of the site.
A bug that prevented quick-links in /qa from being selected was also resolved.
Test URLs: