Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets 32349 #24

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Assets 32349 #24

merged 3 commits into from
Jan 5, 2024

Conversation

cheintzman
Copy link
Collaborator

JIRA: ASSETS-32349

Made changes to dynamically set the href of the adp-logo depending on whether the user is logged in and/or whether the user is navigating the /qa section of the site.

A bug that prevented quick-links in /qa from being selected was also resolved.

Screenshot 2024-01-03 112643

Test URLs:

Copy link

aem-code-sync bot commented Jan 3, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@shiv-gup
Copy link
Collaborator

shiv-gup commented Jan 4, 2024

@cheintzman I am getting redirected to landing page, if I am logged-in and on faq page. Shouldn't user be redirected to /assets page from https://assets-32349--adobe-gmo--hlxsites.hlx.page/faq if user is logged-in?

@cheintzman
Copy link
Collaborator Author

@shiv-gup Yes, that would be the ultimate end goal, however due to the way public pages are handled, the method used here to determine whether a user is logged in cannot be used on public pages. It will require changing/adding code to security.js and security-imslibs.js in order to resolve the issue properly. These changes will get the logo working properly for majority of the site until that gets part resolved.

@shiv-gup
Copy link
Collaborator

shiv-gup commented Jan 4, 2024

@cheintzman can you share the JIRA story where the changes were requested. I feel for now just making the logo image configurable should be good. From all pages if user clicks on logo, the same page user should be redirected to(not dependent on user login status). Please check once with Debbie and Diana for requirement.

@cheintzman
Copy link
Collaborator Author

cheintzman commented Jan 4, 2024

@shiv-gup This is the initial story: DXI-23112

Diana had asked that the /assets page be considered the "home" page once the use is logged in, and the landing page be considered the home page for unauthenticated users. Debbie had mentioned I should make this change after the RCP since the security files needed some more people to be involved in order to resolve it properly.

@cheintzman cheintzman merged commit 9ee90d2 into main Jan 5, 2024
0 of 2 checks passed
@cheintzman cheintzman deleted the ASSETS-32349 branch January 5, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants